Add failOnSkippedAfterRetry option #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adboyarshinov, thank you for the PR. Could you please chime in on this question from the issue? The original reporters did not follow up on it, and I am trying to understand the use case better before we commit to introducing this option. Do you have an example of such a volatile precondition that would cause tests to run, fail, and then be skipped? |
pshevche
requested changes
Sep 9, 2024
There was a problem hiding this comment.
All in all, looks good, well done! I left a couple of comments and suggest the following:
- Let us discuss how exactly this helps. I am still struggling to wrap up my head around the use case.
- Please add a test for this. You can use this test as an example, but I'd recommend adding one to
JUnit5FuncTest.
plugin/src/main/java/org/gradle/testretry/internal/executer/RetryTestResultProcessor.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/gradle/testretry/internal/executer/RetryTestResultProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexander Boyarshinov <[email protected]>
pshevche
reviewed
Sep 10, 2024
plugin/src/test/groovy/org/gradle/testretry/testframework/JUnit4FuncTest.groovy
Show resolved
Hide resolved
pshevche
approved these changes
Sep 10, 2024
|
Thank you for your contribution, @adboyarshinov . We'll try to release it in 1.6.0 as soon as possible, probably this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test is set to be skipped on it's body if certain condition meets, a retried test that is later skipped will fail the build.
Adding this option allows you to choose the behavior you want.
There is issue for this problem:
#130