Migrated from gradle conventions plugin to CCUD plugin #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gasper Kojek <[email protected]>
… as env var Signed-off-by: Gasper Kojek <[email protected]>
Signed-off-by: Gasper Kojek <[email protected]>
Signed-off-by: Gasper Kojek <[email protected]>
pshevche
approved these changes
Aug 2, 2024
runningcode
reviewed
Aug 2, 2024
| - name: "Setup Build Environment" | ||
| uses: ./.github/actions/setup-environment | ||
|
|
||
| - name: 'Setup Gradle' | ||
| uses: gradle/actions/setup-gradle@v3 | ||
| with: |
There was a problem hiding this comment.
do we need the key for the setup action? or just the build action?
There was a problem hiding this comment.
In the setup action the key is used to get the access token, which is then actually used. In the build action it's there more for the remote cache push, since this is an OSS project. I can also remove it from the build action and as a check for remote cache push in the settings.gradle.kts.
| - uses: gradle/gradle-build-action@v3 | ||
|
|
||
| - name: 'Setup Gradle' | ||
| uses: gradle/actions/setup-gradle@v3 | ||
| with: |
There was a problem hiding this comment.
same question as above :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from gradle conventions plugin to CCUD plugin and fixed and updated the Github Actions to enable CI to publish scans and write to remote build cache.