Skip to content

Conversation

@ehs208
Copy link
Contributor

@ehs208 ehs208 commented Jul 20, 2025

Moved the explanatory paragraph to the beginning of the section to provide better context and clarity about why Finalizer tasks are useful.

Fixes #34225

Context

The "Finalizer tasks" section previously started without context, making it harder for readers to understand their purpose and why they are important.
This PR moves the explanatory paragraph to the beginning of the section, improving readability and comprehension for users who are learning about Gradle task execution.

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective. (Not applicable for docs change)
  • Provide unit tests (under <subproject>/src/test) to verify logic. (Not applicable for docs change)
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck. (Docs change, should pass)
  • Ensure that tests pass locally: ./gradlew :docs:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with:

  • ❌ ❓ must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

Moved the explanatory paragraph to the beginning of the section to provide better context and clarity about why Finalizer tasks are useful.

Signed-off-by: ehs208 <[email protected]>
@ehs208 ehs208 requested a review from a team as a code owner July 20, 2025 14:05
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Jul 20, 2025
Copy link
Member

@ov7a ov7a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

This PR is complete and simple enough, it will be merged immediately.

@ov7a ov7a added a:documentation Documentation content and removed to-triage labels Jul 21, 2025
@ov7a ov7a added this pull request to the merge queue Jul 21, 2025
@bot-gradle bot-gradle added this to the 9.1.0 RC1 milestone Jul 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@ov7a ov7a added this pull request to the merge queue Jul 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@ov7a ov7a added this pull request to the merge queue Jul 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@ov7a ov7a added this pull request to the merge queue Jul 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@ov7a ov7a added this pull request to the merge queue Jul 21, 2025
Merged via the queue into gradle:master with commit eb2f679 Jul 21, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:documentation Documentation content from:contributor PR by an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalizer Task description provides no introductory context.

3 participants