Reduce build operation measurement overhead #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce the overhead somewhat.
|
On the Gradle build the median overhead has been reduced significantly:
It's still quite a significant overhead, but it's much better already. Before:
After:
|
|
@wolfs PTAL. I think this is as far as we can go with reducing the overhead. I think it's acceptable at this point, and we also have a better understanding of what's happening. How and why the overhead disappears at times on macOS is still beyond me, though. |
wolfs
requested changes
Sep 10, 2020
subprojects/build-operations/src/main/java/org/gradle/trace/buildops/BuildOperationTrace.java
Show resolved
Hide resolved
subprojects/build-operations/src/main/java/org/gradle/trace/buildops/BuildOperationTrace.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of registering a
BuildOperationListenerfor every build operation type captured, we now add only one that handles all the captured build operations. This reduces the overhead of the observation significantly from 68.5%, though it still stays rather high at 14.1%.Fixes #214