Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use captureFileFingerprints for Maven extension 1.21 #27

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Use captureFileFingerprints for Maven extension 1.21 #27

merged 2 commits into from
Mar 21, 2024

Conversation

alextu
Copy link
Member

@alextu alextu commented Mar 21, 2024

Use develocity.scan.captureFileFingerprints for Maven extension 1.21 and above else gradle.scan.captureGoalInputFiles.
This PR also refactors the unit tests.

pshevche
pshevche approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@pshevche pshevche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, you can just set both system properties. That makes the script a bit simpler, but it is up to you.

@alextu
Copy link
Member Author

alextu commented Mar 21, 2024

Alternatively, you can just set both system properties. That makes the script a bit simpler, but it is up to you.

Good point, will follow this approach as I think in other CI integrations

@alextu alextu requested a review from guylabs March 21, 2024 13:45
@alextu alextu merged commit f23c3b2 into main Mar 21, 2024
2 of 4 checks passed
@alextu alextu deleted the atual/mvn-fingerprints branch March 21, 2024 13:50
@alextu alextu added the enhancement New feature or request label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshevche pshevche pshevche approved these changes

@guylabs guylabs guylabs approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alextu @guylabs @pshevche