-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject and configure the Develocity extension #22
Inject and configure the Develocity extension #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me minus a few styling comments, TODOs on my side after this PR is merged:
- Fix the default CCUD coordinates and add unit test
- Add a smoke test on our GitLab project for injection with Develocity 1.21
fi | ||
echo "${coordinates}" | ||
} | ||
|
||
function ccudCoordinates() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw a bug on the line below I'll fix in a subsequent PR (wrong default CCUD coordinates)
Summary
Reviewing commit-by-commit should be pretty straight-forward. The Maven template has been updated to: