Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject and configure the Develocity extension #22

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Inject and configure the Develocity extension #22

merged 11 commits into from
Mar 19, 2024

Conversation

pshevche
Copy link
Member

Summary

Reviewing commit-by-commit should be pretty straight-forward. The Maven template has been updated to:

  1. Download the Develocity/Gradle Enterprise extension based on the version specified.
  2. Inject the downloaded extension only if neither custom nor Develocity nor GE extension is applied.
  3. Configure both the Develocity and GE extensions.

Copy link
Member

@alextu alextu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me minus a few styling comments, TODOs on my side after this PR is merged:

  • Fix the default CCUD coordinates and add unit test
  • Add a smoke test on our GitLab project for injection with Develocity 1.21

develocity-maven.yml Outdated Show resolved Hide resolved
develocity-maven.yml Outdated Show resolved Hide resolved
fi
echo "${coordinates}"
}

function ccudCoordinates() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw a bug on the line below I'll fix in a subsequent PR (wrong default CCUD coordinates)

@alextu alextu merged commit 03a9fdd into gradle:main Mar 19, 2024
1 of 2 checks passed
@pshevche pshevche deleted the pshevche/use-develocity-extension branch March 20, 2024 12:51
@alextu alextu added the enhancement New feature or request label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants