Add TODO for future direction in the value factory index

gradle · Feb 19, 2025 · fab2d86 · fab2d86
1 parent d59b830
commit fab2d86
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/lsp/src/main/kotlin/org/gradle/declarative/lsp/DeclarativeTextDocumentService.kt b/lsp/src/main/kotlin/org/gradle/declarative/lsp/DeclarativeTextDocumentService.kt
@@ -509,6 +509,10 @@ private class ValueFactoryIndex(storeEntry: DocumentStoreEntry) {
         indexValueFactories(schema, schema.topLevelReceiverType, "")
     }
 
+    // TODO: currently this index contains all value factories from the whole schema
+    //  going forward we should make it take into account which value factory is available
+    //  in which block, because only the ones defined at the top level are available everywhere
+
     fun factoriesForProperty(fqName: FqName): List<LabelAndInsertText>? = index[fqName]
 
     private fun indexValueFactories(analysisSchema: AnalysisSchema, type: DataClass, namePrefix: String): Map<FqName, List<LabelAndInsertText>> {