-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially refactor to use more idiomatic Gradle #241
Conversation
Looks like failure is due to #228 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! I'm curious too, @szpak, if this is a desired changeset to continue working on? Probably the best time for 2.0. I would be happy to help on this.
src/main/kotlin/io/github/gradlenexus/publishplugin/NexusPublishPlugin.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/github/gradlenexus/publishplugin/NexusPublishExtension.kt
Show resolved
Hide resolved
src/main/kotlin/io/github/gradlenexus/publishplugin/NexusPublishExtension.kt
Show resolved
Hide resolved
I have to admit, I don't closely follow the recent changes in Gradle and how the "idiomatic Gradle" looks like in 2023 :-/. However, in general those changes look fine as simplifications and especially with the already mentioned Robert's branch, they would be nicely fit in the upcoming 2.0.0. |
src/main/kotlin/io/github/gradlenexus/publishplugin/NexusPublishPlugin.kt
Show resolved
Hide resolved
I think this is good as it is and can be merged, I'm happy to pick up and rebase my branch on top. I can also fix #241 (comment) there. |
Thanks @3flex for the PR and @TWiStErRob for the code review!
Sound good. |
The main changes are:
Project
aroundParts 1 & 3 are not fully completed but I didn't want to press on if this wasn't desired. This should be safe to merge as is though as compat tests for Gradle 6 on Java 11 pass locally.