Don't share state via NexusRepository #11
Conversation
marcphilipp
commented
Jan 11, 2020
marcphilipp
commented
- Remove stagingProfileId from close/release tasks as it is not needed
- Wire stagingRepositoryId for close/release task in plugin
- Remove mutable state from NexusRepository
- Rename CLI option to --staging-repository-id to make it more idiomatic
- Remove stagingProfileId from close/release tasks as it is not needed - Wire stagingRepositoryId for close/release task in plugin - Remove mutable state from NexusRepository - Rename CLI option to --staging-repository-id to make it more idiomatic
|
|
||
| @Optional | ||
| @Input | ||
| val packageGroup = objects.property<String>().apply { |
There was a problem hiding this comment.
+1, packageGroup is not important for close and release.
| project.tasks.register("publishTo${capitalizedName()}") { | ||
| description = "Publishes all Maven publications produced by this project to the '${[email protected]}' Nexus repository." | ||
| group = PublishingPlugin.PUBLISH_TASK_GROUP | ||
| } | ||
| project.tasks | ||
| .register<InitializeNexusStagingRepository>("initialize${capitalizedName()}StagingRepository", project.objects, extension, this, serverUrlToStagingRepoUrl) | ||
| .register<InitializeNexusStagingRepository>("initialize${capitalizedName()}StagingRepository", project.objects, extension, this, serverUrlToStagingRepoUrl, { id: String -> stagingRepositoryId.set(id) }) |
There was a problem hiding this comment.
I like the trick to use a function to set (and later use) dangling property in not directly bound contexts. It greatly reduced complexity of the workaround on finalized properties in Gradle.
|
|
||
| @get:Input | ||
| val snapshotRepositoryUrl: Property<URI> = project.objects.property() | ||
| @Input |
There was a problem hiding this comment.
Tests confirms it works, but the related documentation doesn't cover that topic:
This annotation should be attached to the getter method in Java or the property in Groovy. Annotations on setters or just the field in Java are ignored.
Is it the recommenced approach for Kotlin? Then I could propose JavaDoc improvement to: or the property in Groovy/Kotlin.
There was a problem hiding this comment.
I'll bring this up with the Gradle team.
There was a problem hiding this comment.
It's now an issue: gradle/gradle#11927
