Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

null passed for credentails (at least) in e2e-tests #267

Closed
szpak opened this issue Sep 1, 2023 · 0 comments · Fixed by #274
Closed

null passed for credentails (at least) in e2e-tests #267

szpak opened this issue Sep 1, 2023 · 0 comments · Fixed by #274
Labels
bug Something isn't working
Milestone
2.0.0

Comments

@szpak
Copy link
Contributor

szpak commented Sep 1, 2023

After 535705a the e2e-tests fails with 401 Unauthorized. Some quick debugging shows that null values are passed for credentials. To be verified if there is problem with passing the values from e2e-tests or (rather) how to fix a regression which might affect also regular plugin users.
@szpak szpak added the bug Something isn't working label Sep 1, 2023
szpak added a commit that referenced this issue Sep 1, 2023
@szpak
Revert "Gradle 6.2 as minimum (#251)"
802a328 
This reverts commit 535705a.

Workaround for "null" values in credentails. See:
#267
@szpak szpak mentioned this issue Sep 1, 2023
Merged
szpak added a commit that referenced this issue Sep 1, 2023
@szpak
Revert "Gradle 6.2 as minimum (#251)" (#268)
68672fd 
This reverts commit 535705a.

Workaround for "null" values in credentials. See:
#267
@szpak szpak added this to the 2.0.0 milestone Sep 1, 2023
TWiStErRob added a commit to TWiStErRob/nexus-publish-gradle-plugin that referenced this issue Sep 18, 2023
@TWiStErRob
Revert "Use providers.gradleProperty (Gradle 6.2)" to not run into gr…
8e96e5e 
…adle-nexus#267

This reverts commit f658356
@TWiStErRob TWiStErRob mentioned this issue Sep 18, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2024
@TWiStErRob @szpak
Gradle 6.2 as minimum (re-merge of #251) (#274)
ecfc17e 
* Bump minimum version to Gradle 6.1

* Use build service all the way (Gradle 6.1)

* Bump minimum version to Gradle 6.2

* Use providers.gradleProperty (Gradle 6.2)

* forUseAtConfigurationTime compatibility

* Use full plugin name in error message

Co-authored-by: Róbert Papp <[email protected]>

* Revert "Use providers.gradleProperty (Gradle 6.2)" to not run into #267

This reverts commit f658356

---------

Co-authored-by: Marcin Zajączkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Gradle 6.2 as minimum (re-merge of #251) TWiStErRob/nexus-publish-gradle-plugin
1 participant
@szpak