Added Liberica Native Image Kit as new distribution #87
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
.github/workflows/test.yml
Outdated
| with: | ||
| distribution: liberica | ||
| java-version: ${{ matrix.java-version }} | ||
| version: ${{ matrix.version }} |
There was a problem hiding this comment.
We actually am phasing out version in favor of just the java-version. It seems there are different variants of Liberica. Can these also be pulled by setup-java and if yes, how?
There was a problem hiding this comment.
AFAICT this is controlled by the java-package parameter:
java-package: The packaging variant of the chosen distribution. Possible values: jdk, jre, jdk+fx, jre+fx. Default value: jdk
The value of jdk corresponds to version: std, and jdk+fx corresponds to version: full
There was a problem hiding this comment.
Thanks! Mapping jdk+fx to full seems like a hack, assuming fx stands for JavaFX? If Liberica users are more familiar with std and full, I'm ok with using those directly, maybe also allowing jdk and jdk+fx for full compatibility with setup-java. In any case, we should add the java-package input from setup-java and not use the version input for this.
There was a problem hiding this comment.
Ok, I've added the java-package: jdk | jdk+fx input
|
Hi, I was Fixed 'version' parameter at this Pull |
|
The failure on Windows is unrelated to this PR. I'll take care of it. |
This PULL also fixed the issue of not being able to download the latest version of graalvm. |
|
Addressed rest of the comments |
|
This is now live and available via |
This PR addresses #76. Liberica is supported in pretty much the same fashion as GraalVM, e.g.
It appeared logical to me to reuse several functions from
utils.ts, so I converted a few constants used there into parameters. Also added tests, notes, and bumped version.