Move JUnit tests to get started #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
ban-mi
commented
Sep 2, 2025
olyagpl
previously approved these changes
Sep 3, 2025
vjovanov
reviewed
Sep 3, 2025
vjovanov
reviewed
Sep 3, 2025
ban-mi
commented
Sep 3, 2025
Collaborator
|
Is this PR ready for merge? |
Member
Author
dnestoro
reviewed
Sep 23, 2025
| testImplementation 'org.junit.jupiter:junit-jupiter-api:5.8.1' | ||
| testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.8.1' | ||
| testImplementation 'junit:junit:4.13.2' | ||
| ---- |
Collaborator
There was a problem hiding this comment.
@melix correct me if I am wrong, but since version 0.11.0 users should add the following as well?
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
Collaborator
There was a problem hiding this comment.
It depends on the version of Gradle. Since 8.14 they have to.
Collaborator
Member
There was a problem hiding this comment.
Isn't this requirement independent of the plugin usage?
Collaborator
There was a problem hiding this comment.
If I am not wrong, with earlier versions of NBT, users did not have to add this dependency themselves. When we fixed the issue with "leaking" dependencies (release 0.11.0), we stopped providing this dependency by ourselves, and required users to do so (but we fixed other bugs caused by leaking JUnit dependencies).
@melix please correct me if I missed something since you implemented fix for leaking dependencies.
See this comment: #712 (comment)
Collaborator
|
@ban-mi As we want to have a new release as soon as possible to unblock Micronaut, I am going to merge this PR, and suggest some changes in a follow-up PR. |
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Oct 7, 2025
…1.0 to 0.11.1 [skip ci] Bumps [org.graalvm.buildtools:native-maven-plugin](https://github.com/graalvm/native-build-tools) from 0.11.0 to 0.11.1. Release notes *Sourced from [org.graalvm.buildtools:native-maven-plugin's releases](https://github.com/graalvm/native-build-tools/releases).* > 0.11.1 > ------ > > What's Changed > -------------- > > * Create release 0.11.0 by [`@brahimhaddou`](https://github.com/brahimhaddou) in [graalvm/native-build-tools#746](https://github.com/graalvm/native-build-tools/pull/746) > * bump version to 0.11.1 SNAPSHOT by [`@brahimhaddou`](https://github.com/brahimhaddou) in [graalvm/native-build-tools#749](https://github.com/graalvm/native-build-tools/pull/749) > * [GR-68095] Change links in the Native Build Tools Gradle page by [`@ban-mi`](https://github.com/ban-mi) in [graalvm/native-build-tools#753](https://github.com/graalvm/native-build-tools/pull/753) > * Group annotations by dependency and print a warning if the dependency is missing by [`@dnestoro`](https://github.com/dnestoro) in [graalvm/native-build-tools#752](https://github.com/graalvm/native-build-tools/pull/752) > * Fix configuration cache compatibility in generating excluded args by [`@bacecek`](https://github.com/bacecek) in [graalvm/native-build-tools#763](https://github.com/graalvm/native-build-tools/pull/763) > * Remove the default Maven phase bound to the `metadata-copy` Maven goal to simplify the use of integration tests by [`@linghengqian`](https://github.com/linghengqian) in [graalvm/native-build-tools#748](https://github.com/graalvm/native-build-tools/pull/748) > * Prepare SBOM integration for GraalVM 25 by [`@rudsberg`](https://github.com/rudsberg) in [graalvm/native-build-tools#759](https://github.com/graalvm/native-build-tools/pull/759) > * Add testing of Gradle 9 by [`@melix`](https://github.com/melix) in [graalvm/native-build-tools#766](https://github.com/graalvm/native-build-tools/pull/766) > * supporting jdk toolchain configuration by [`@SergeDemoulinGebit`](https://github.com/SergeDemoulinGebit) in [graalvm/native-build-tools#622](https://github.com/graalvm/native-build-tools/pull/622) > * Move JUnit tests to get started by [`@ban-mi`](https://github.com/ban-mi) in [graalvm/native-build-tools#767](https://github.com/graalvm/native-build-tools/pull/767) > * Disable layered images test temporarily because of a problem on GralVM side by [`@dnestoro`](https://github.com/dnestoro) in [graalvm/native-build-tools#772](https://github.com/graalvm/native-build-tools/pull/772) > * Add new JUnit 5.14/6.0 types to initialize-at-build-time classes by [`@marcphilipp`](https://github.com/marcphilipp) in [graalvm/native-build-tools#771](https://github.com/graalvm/native-build-tools/pull/771) > * Prepare repository for release `0.11.1` by [`@dnestoro`](https://github.com/dnestoro) in [graalvm/native-build-tools#770](https://github.com/graalvm/native-build-tools/pull/770) > > New Contributors > ---------------- > > * [`@ban-mi`](https://github.com/ban-mi) made their first contribution in [graalvm/native-build-tools#753](https://github.com/graalvm/native-build-tools/pull/753) > * [`@bacecek`](https://github.com/bacecek) made their first contribution in [graalvm/native-build-tools#763](https://github.com/graalvm/native-build-tools/pull/763) > * [`@SergeDemoulinGebit`](https://github.com/SergeDemoulinGebit) made their first contribution in [graalvm/native-build-tools#622](https://github.com/graalvm/native-build-tools/pull/622) > > **Full Changelog**: <graalvm/native-build-tools@0.11.0...0.11.1> Commits * [`6545631`](graalvm/native-build-tools@6545631) Create release 0.11.1 * [`359acfb`](graalvm/native-build-tools@359acfb) Update licenses to pass style check * [`7327427`](graalvm/native-build-tools@7327427) Add changelog entries * [`73d17cc`](graalvm/native-build-tools@73d17cc) Update Reachability metadata version * [`eb52764`](graalvm/native-build-tools@eb52764) Add new JUnit 5.14/6.0 types to initialize-at-build-time classes * [`f94e6d6`](graalvm/native-build-tools@f94e6d6) Disable layered images test temporarily because of a problem on GraalVM side * [`200e23c`](graalvm/native-build-tools@200e23c) Update docs/src/docs/asciidoc/end-to-end-gradle-guide.adoc * [`079f06d`](graalvm/native-build-tools@079f06d) Move JUnit tests to get started * [`50d8fbb`](graalvm/native-build-tools@50d8fbb) supporting jdk toolchain configuration * [`77b4cfb`](graalvm/native-build-tools@77b4cfb) Add testing of Gradle 9 * Additional commits viewable in [compare view](graalvm/native-build-tools@0.11.0...0.11.1) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.