Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce GraalVM JDK 23 #59

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Introduce GraalVM JDK 23 #59

merged 3 commits into from
Sep 17, 2024

Conversation

brahimhaddou
Copy link
Member

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 17, 2024
@ezzarghili ezzarghili self-requested a review September 17, 2024 11:59
@fniephaus
Copy link
Member

Thanks for the PR! Could you please add 23 to the build matrix so that this is tested?

homebrew-tap/.github/workflows/main.yml

Line 11 in d8d12ef

java-version: [17, 20, 21, 22]

@ezzarghili
Copy link
Member

ezzarghili commented Sep 17, 2024 •
edited
Loading

Thanks for the PR! Could you please add 23 to the build matrix so that this is tested?

homebrew-tap/.github/workflows/main.yml

Line 11 in d8d12ef

java-version: [17, 20, 21, 22]

@fniephaus maybe remove EOL versions there ? 20 and 22

ezzarghili
ezzarghili previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@ezzarghili ezzarghili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fniephaus
Copy link
Member

maybe remove EOL versions there ? 20 and 22

I would've kept them, you can still install them.

fniephaus
fniephaus previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezzarghili
Copy link
Member

ezzarghili commented Sep 17, 2024 •
edited
Loading

maybe remove EOL versions there ? 20 and 22

I would've kept them, you can still install them.

We are not removing the actual artifacts. they are not supported and will not get update, I think running tests on them is not necessary and wasteful of CI resources

@fniephaus
Copy link
Member

I think running tests on them is not necessary and wasteful of CI resources

Good point, I agree.

ezzarghili
ezzarghili approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@ezzarghili ezzarghili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ezzarghili ezzarghili merged commit cc0fb87 into graalvm:master Sep 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezzarghili ezzarghili ezzarghili approved these changes

@fniephaus fniephaus fniephaus approved these changes

Assignees

@ezzarghili ezzarghili

@brahimhaddou brahimhaddou

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brahimhaddou @fniephaus @ezzarghili