Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to skip pull request creation #704

Closed

Conversation

lfgcampos
Copy link
Contributor

For one of the use cases I have with this action, I would like to skip the PR creation based on a given parameter.

For example, when running this workflow against master or main branch, I'd like to see a PR.
But when running against a different branch, I would like to have my whole automation to run, have the branch creation, the commit but not a PR to avoid human mistake and unwanted merged.

Adding this option should cover this use case I have but also probably different use cases from the community.

@gr2m
Copy link
Owner

gr2m commented Sep 26, 2024

It does feel odd that creating a pull request is in the name of the action and then you can turn of that feature. I'm not sure about this one, I'd rather say it's out of scope

@lfgcampos
Copy link
Contributor Author

It does feel odd that creating a pull request is in the name of the action and then you can turn of that feature. I'm not sure about this one, I'd rather say it's out of scope

I understand your concern and I am happy with your choice =)

My use case is valid though and adding an extra action to commit a file while replacing this action (or using it for certain specific use cases only) is a route I would like to skip

As you can see, the default param value will make sure the action work as is.

But if this is something you won't consider anyway, feel free to close the PR then 🙁

@gr2m
Copy link
Owner

gr2m commented Sep 30, 2024

But if this is something you won't consider anyway, feel free to close the PR then 🙁

Yeah sorry I think I'll pass.

I think in an ideal world there would be an action to update multiple files in a branch which would use most of the logic in this action. And then this action would just create the pull request, basically split it up into two. But I don't have time to work on that unfortunately

@gr2m gr2m closed this Sep 30, 2024
@lfgcampos
Copy link
Contributor Author

But if this is something you won't consider anyway, feel free to close the PR then 🙁

Yeah sorry I think I'll pass.

I think in an ideal world there would be an action to update multiple files in a branch which would use most of the logic in this action. And then this action would just create the pull request, basically split it up into two. But I don't have time to work on that unfortunately

are you fine if I fork it then and adjust to my use case?
as you said, most of the work is already done

@lfgcampos lfgcampos mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants