-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow recording IQ samples in the SigMF format #1182
Conversation
Hello.
|
Huh. It built fine on my Arch machine but I just tested it again on Ubuntu and was able to reproduce that issue. I think this might be because Arch defaults to C++17 (where X a = X() is not a copy) and Ubuntu defaults to C++14 (where it is). If that is the issue then it should be easy to fix. |
That issue should be fixed with the new commit. |
Confirmed. It builds and writes .sigmf-meta file. |
Thanks for this, and sorry for the long delay in looking at it. I'm starting to have a peek now. I'd love to see at least partial SigMF support in the next Gqrx release. |
Thank you for having a look. Let me know if there is anything else that I can do for this. I took this as far as I needed for my use case at the time but I'm happy to do more work on this if there is interest. |
It might be nice to store the device name and/or device string in the |
I merged the suggestions, rebased, and updated the news & contributors list. I'll merge once CI is happy. |
A couple more things we could potentially include in sigmf-meta:
|
This implements part 1 of #988. Users can choose between the old format (raw) and SigMF with a chooser in the iq tool window.
Since SigMF keeps metadata and signal data separate, the actual recording remains unchanged regardless of which format is selected (except for the file name). For this reason,
.sigmf-data
files are made available for playback in the iq tool as well (this does not work in the general case (yet) but.raw
isn't super well defined either).One potential improvement would be to do some refactoring to separate formats into different classes that can be interacted with during the recording. This would 1. more cleanly separate the code paths for raw and sigmf recordings and 2. allow adding more metadata during the recording (e.g. we could start a new
capture
object when we tune the radio to a different frequency or change the gain).