Improve accuracy and precision of S-meter display #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1054 (comment),
m_Siglevelis currently anint, limiting the precision of the displayed S-meter on high-DPI displays. I've fixed that in the first commit here.While working on this, I also noticed that the S-meter rectangle is 2 pixels too short. It has a black pen stroke around it which is the correct length, but that cannot be seen. I've made the stroke visible by changing it to green. (It was easier to get the meter to the correct size this way, as opposed to removing the stroke completely.) This change is in the second commit.