fix: sdkserver: credentials: ensure credential helpers exist #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
thedadams,
StrongMonkey,
iwilltry42 and
tylerslaton
| @@ -108,6 +109,7 @@ func run(ctx context.Context, listener net.Listener, opts Options) error { | |||
| token: token, | |||
| client: g, | |||
| events: events, | |||
| runtimeManager: runtimes.Default(opts.Options.Cache.CacheDir), // TODO - do we always want to use runtimes.Default here? | |||
There was a problem hiding this comment.
I like how you have moved the comment :)
|
Always good to add a small description about the PR to have more contex |
StrongMonkey
approved these changes
Sep 13, 2024
drpebcak
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDKServer was assuming that credential helpers were already present, which causes problems when they aren't there.