feat: download binaries for cred helpers #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42 and
g-linville
thedadams
force-pushed
the
cred-helper-releases
branch
from
fdf20f5
to
0a585c2
Compare
g-linville
approved these changes
Aug 14, 2024
pkg/repos/get.go
Outdated
| if helperName == "wincred" { | ||
| suffix = ".exe" | ||
| } | ||
|
|
||
| // The file helper is built-in and does not need to be compiled. |
There was a problem hiding this comment.
super nit
Suggested change
| // The file helper is built-in and does not need to be compiled. | |
| // The file helper is built-in and does not need to be downloaded. |
pkg/repos/get.go
Outdated
| return err | ||
| } | ||
| } else if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if !needsBuild { | ||
| if !needsDownloaded { | ||
| // Check for the existence of the gptscript-credential-osxkeychain binary. |
There was a problem hiding this comment.
nit:
Suggested change
| // Check for the existence of the gptscript-credential-osxkeychain binary. | |
| // Check for the existence of the credential helper binary. |
(I should have fixed this myself before but evidently missed it.)
| // Check for the existence of the gptscript-credential-osxkeychain binary. | ||
| // If it's there, we have no need to build it and can just return. | ||
| if _, err := os.Stat(filepath.Join(m.credHelperDirs.BinDir, "gptscript-credential-"+helperName+suffix)); err == nil { | ||
| if _, err = os.Stat(filepath.Join(m.credHelperDirs.BinDir, "gptscript-credential-"+helperName+suffix)); err == nil { | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| // Find the Go runtime and use it to build the credential helper. |
There was a problem hiding this comment.
nit:
Suggested change
| // Find the Go runtime and use it to build the credential helper. | |
| // Find the Go runtime and use it to download the credential helper. |
StrongMonkey
approved these changes
Aug 14, 2024
iwilltry42
approved these changes
Aug 14, 2024
Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
cred-helper-releases
branch
from
0a585c2
to
5c60812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.