-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better handling of OpenAPI tools #667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-linville
requested review from
thedadams,
njhale,
StrongMonkey,
tylerslaton and
iwilltry42
July 29, 2024 15:37
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
iwilltry42
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a monster O.o
Good Job!
Left some comments...
Signed-off-by: Grant Linville <[email protected]>
g-linville
force-pushed
the
openapi-revamp
branch
from
July 29, 2024 19:08
b4ffc57
to
a15d9ae
Compare
iwilltry42
approved these changes
Jul 30, 2024
thedadams
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just nits.
Signed-off-by: Grant Linville <[email protected]>
thedadams
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we handle OpenAPI tools. Rather than generating an individual tool for each operation in the OpenAPI file, we always generate three tools:
list
,getSchema
, andrun
. These basically act as an interface around the OpenAPI file. The LLM callslist
to find out about all of the available operations. It then callsgetSchema
to get the JSONSchema for the args for a particular operation. It can then call that operation with therun
tool by providing the name of the operation and the JSON string for the args.Right now this is hidden behind the
GPTSCRIPT_OPENAPI_REVAMP
environment variable.