-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix potential github action smells #1156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an appreciated contribution!
Note that you have to remove a trailing white space to pass the last check.
Please answer the specific question.
@@ -23,7 +31,7 @@ jobs: | |||
cache: 'pip' #Note that pip is for the tox level. Poetry is still used for installing the specific environments (tox.ini) | |||
|
|||
- name: Install tox | |||
run: pip install tox | |||
run: pip install tox==4.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if you explained why this change is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to keep the pipeline as consistent as possible between runs, and to make sure it is the developer's conscious decision to use the next version during the workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on consistency, I was curious whether there was a reason for this specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah oke, this is just the current version, that's why.
@ATheorell Thank you for the feedback. I've removed the trailing white spaces and replied to your comments. |
Thanks for the explanation! pre-commit doesn't seem to agree about the trailing whitespace. |
- Avoid installing packages without version - Define permissions for workflows with external actions - Avoid running CI related actions when no source code has changed - Stop running workflows when there is a newer commit in PR
Ah yes I see I forgot one by accident! This is now fixed as well :) |
Hey! 🙂
I've made the following changes to the workflow:
(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)