Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate https://github.com/grails/scaffolding-old into fields plugin #363

Closed
wants to merge 5 commits into from

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Sep 23, 2024

Fields is the only current plugin still using org.grails:scaffolding-core:2.1.0 which comes from https://github.com/grails/scaffolding-old and is archived. It was last released in 2019.

https://github.com/grails/scaffolding does not use https://github.com/grails/scaffolding-old (org.grails:scaffolding-core), so the decision was made to put the code in fields.

The code and docs have been incorporated directly into fields so that the code can be maintained here.

11 failing tests are currently ignored in this PR: 384dd19

This PR adds 114 passing tests for the scaffolding-old code.

@jamesfredley jamesfredley linked an issue Sep 23, 2024 that may be closed by this pull request
@codeconsole
Copy link
Contributor

codeconsole commented Sep 23, 2024

@jamesfredley did you bring over the git history? If not, we should hold off. It's no difficult to do. you just add it as another source

Copy link
Contributor

@codeconsole codeconsole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a subproject. All that is needed is to add the folder of the entire repo and add it to settings.gradle. That way all history is preserved. Alternatively we can unarchive the original project and keep it separate.

@jamesfredley
Copy link
Contributor Author

@codeconsole the current situation with org.grails:scaffolding-core:2.1.0 and org.grails.plugins:scaffolding:6.0.0-SNAPSHOT is confusing, since they are not related and org.grails.plugins:scaffolding does not use org.grails:scaffolding-core.

Since org.grails:scaffolding-core is only used in Fields, I think that moving the code into it directly is the best place for it to live and evolve with that Plugin. The code was quite stale since it was out of sight in that old jar for the last 5 years.

I'll bring the git history (64 commits) over.

@jamesfredley
Copy link
Contributor Author

replaced by #364

@jamesfredley jamesfredley deleted the incorporate-shaffolding-old branch September 23, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org.grails:scaffolding-core:2.1.0 dependency
2 participants