Allow customization of default wrapper in order to support Bootstrap without requiring templates #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbglasius
requested changes
Sep 13, 2024
grails-app/taglib/grails/plugin/formfields/FormFieldsTagLib.groovy
Outdated
Show resolved
Hide resolved
| if (k?.startsWith(prefixAttribute)) | ||
| widgetAttrs[k.replace(prefixAttribute, '')] = v | ||
| else | ||
| wrapperAttrs[k] = v | ||
| } | ||
|
|
||
| List classes = [widgetAttrs['class']?:''] | ||
| if (model.invalid) classes << (widgetAttrs.remove('invalidClass')?:'') | ||
| if (model.required) classes << (widgetAttrs.remove('requiredClass')?:'') |
There was a problem hiding this comment.
To follow the code-style (if any) of the existing code, add spaces around ?: (throughout changes)
grails-app/taglib/grails/plugin/formfields/FormFieldsTagLib.groovy
Outdated
Show resolved
Hide resolved
jamesfredley
approved these changes
Sep 13, 2024
|
@jamesfredley existing tests should verify functionality because all the new attributes have existing defaults. If the code changed any existing behavior, the unit tests would fail. I am a little hesitant to add a unit tests for any new capabilities because, with consensus from everyone, I would like to completely change the default behavior for 7.0. |
|
@codeconsole ok, if it is all going to change, the test would be short lived and unneeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Objective
Reduce the amount of code in generate-app to the least amount possible while still maintaining readability and structure.
It is here for review and feedback
Design Decisions:
<li><label></label><div>widget</div></li>pattern is needed. To maintain backwards compatibility, the div is only injected if thedivClassattribute is present.