-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox-#2128 named segment selection #4
base: iox-#2128-publish-options-segment-name
Are you sure you want to change the base?
Iox-#2128 named segment selection #4
Conversation
e4ba809
to
a28d59f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments and looks good overall.
{ | ||
if (segment.getSegmentName() == name) | ||
{ | ||
//Verify that the user has write access to this segment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//Verify that the user has write access to this segment. | |
// Verify that the user has write access to this segment. |
[nit]
// None was found so we return the default info. | ||
return err(SegmentLookupError::NoWriteAccess); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this comment apply to the lower return
statement instead? If so, can you add another comment to this return
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, comment was left over from my POC implementation. This code here used to return default structures which I found ugly and decided to refactor to expected return types.
optional<std::reference_wrapper<MemoryManager>> m_memoryManager; | ||
MemoryManager& m_memoryManager; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You simplified the usage of the return value for the caller, nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this was weird. I think it must have been written before iox::expected
existed and nobody ever bothered refactoring after the fact.
…ake the segment name into account
a28d59f
to
f2fe240
Compare
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
PR #3 in the chain implementing eclipse-iceoryx#2128 whose design is described here
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References