Iox-#2128 named segment selection #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpalmer-latai
force-pushed
the
iox-#2128-named-segment-selection
branch
from
e4ba809
to
a28d59f
Compare
anolley-latai
approved these changes
Jan 22, 2024
| { | ||
| if (segment.getSegmentName() == name) | ||
| { | ||
| //Verify that the user has write access to this segment. |
There was a problem hiding this comment.
Suggested change
| //Verify that the user has write access to this segment. | |
| // Verify that the user has write access to this segment. |
[nit]
| // None was found so we return the default info. | ||
| return err(SegmentLookupError::NoWriteAccess); |
There was a problem hiding this comment.
Should this comment apply to the lower return statement instead? If so, can you add another comment to this return as well?
There was a problem hiding this comment.
Sorry, comment was left over from my POC implementation. This code here used to return default structures which I found ugly and decided to refactor to expected return types.
Comment on lines
-81
to
+82
| optional<std::reference_wrapper<MemoryManager>> m_memoryManager; | ||
| MemoryManager& m_memoryManager; |
There was a problem hiding this comment.
You simplified the usage of the return value for the caller, nice!
There was a problem hiding this comment.
Yeah this was weird. I think it must have been written before iox::expected existed and nobody ever bothered refactoring after the fact.
…ake the segment name into account
gpalmer-latai
force-pushed
the
iox-#2128-named-segment-selection
branch
from
a28d59f
to
f2fe240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch)iox-#123 commit text)task-list-completed)iceoryx_hoofsare added to./clang-tidy-diff-scans.txtNotes for Reviewer
PR #3 in the chain implementing eclipse-iceoryx#2128 whose design is described here
Checklist for the PR Reviewer
iceoryx_hoofshave been added to./clang-tidy-diff-scans.txtPost-review Checklist for the PR Author
References