Fix phpstan removing null on iterable value #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlakomski
reviewed
Jun 6, 2022
.github/workflows/main.yml
Outdated
| @@ -31,6 +31,9 @@ jobs: | |||
| - name: "PHPStan" | |||
| run: ./bin/phpstan analyze -l 8 src examples tests/GenericCases | |||
There was a problem hiding this comment.
Maybe we should remove GenericCases from here?
There was a problem hiding this comment.
Removed. I've moved examples to level 9 too.
Unfortunately, main src directory must stay on level 8, because on 9 there are too many false positives related to generics in plain strings array
There was a problem hiding this comment.
Like this:
------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line src/PlainString.php
------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------
274 Parameter #1 $strings of class GW\Value\PlainStringsArray constructor expects GW\Value\ArrayValue<GW\Value\StringValue|string>, GW\Value\ArrayValue<string> given.
294 Parameter #1 $strings of class GW\Value\PlainStringsArray constructor expects GW\Value\ArrayValue<GW\Value\StringValue|string>, GW\Value\ArrayValue<string> given.
------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------
dlakomski
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.