Bau add frontend translations for demo #1696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latifcabinetoffice
changed the base branch from
main
to
OLH-2152-update-companies-house-signed-in-state-url
|
Base automatically changed from
OLH-2152-update-companies-house-signed-in-state-url
to
main
September 19, 2024 11:59
|
Hey Latif, not sure if we need this as there is currently no frontend on demo, or is it breaking something? |
|
Not breaking anything - but noticed we add 6 translations per file on the frontend and 7 on the backend so thought it would be worth making it consistent |
|
not currently needed - closing PR. |
latifcabinetoffice
deleted the
BAU-add-frontend-translations-for-demo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
BAU Add translations for frontend demo account
What changed
Added translation's for demo account
Why did it change
New environment demo requires translations. Backend has been configured already.
Checklists
Environment variables or secrets