[DO NOT MERGE] OLH-1263: Bump govuk-frontend to v5 #1149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement changes required to update govuk-frontend to the latest version which is a breaking one, removing JS support for <IE11, introducing breaking updates to the JS API, amongst other changes. - update SASS/JS/asset load paths to include /dist: everything in the package has been moved to a dist folder - update the way components are intialised and imported - reformat showPassword component to match the new format of Design System components - remove $govuk-new-link-styles flag from the application sass file as the new styles are no longer opt-in only - load cookies script separately as a normal script while all other application JS is loaded as a <script type="module">
Update account home's version of the header component as per the release notes: - remove ie8 conditional from header - remove <span class="govuk-header__logotype-text"> and its content and update the SVG to the supplied version - remove span wrapper around the svg
danacotoran
force-pushed
the
OLH-1220-govuk-frontend
branch
from
4fc7751
to
706678b
Compare
|
Please hold off on merging this - still checking with the UCD leads about the visual changes. |
danacotoran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Implement changes required to update
govuk-frontendto the latest version which is a breaking one, removing JS support for <IE11, introducing breaking updates to the JS API, amongst other changes./dist: everything in the package has been moved to adistfolderGOVUKFrontendwindow global has been removed, plus you no longer need to call theinitmethod to initialise a componentapplication.js– I did this usingrollupbut if anyone has opinions feel free to share$govuk-new-link-stylesflag from the application sass file as the new styles are no longer opt-in only<script type="module"><span class="govuk-header__logotype-text">and its content from the header and update the SVG to the supplied versionspanwrapper around thesvgin the headerWhy did it change
The latest update to the package introduces breaking changes
Related links
Checklists
Environment variables or secrets
Testing
Tested manually in dev and on local, checking that components are working, cookie functionality is preserved, and
application.jscontains only scripts of components we are using in account management.How to review
Please check the release notes for v5 and highlight if anything isn't covered in this PR.
Check that no breaking changes were introduced as a result of this update, for instance: