AUT-3725: Redirect to error page if enter password response returns m… #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issing or invalid session This error response means that we cannot continue. However, at the moment we fall through to the default error behaviour, which is to reload the page with a validation error, making it seem like the user entered the incorrect password. This handles an edge case in reauthentication whereby the user is logged in in two tabs, starts a reauth journey in another up until the point of entering a password, and then logs out in the first tab. At this point, they will enter an infinite loop of seeming password validation errors regardless of password, whereas in fact the backend is totally unable to proceed. It's also possible to replicate this in the signin journey, although you have to be very specific with timings.
BeckaL
force-pushed
the
AUT-3725/return-error-for-no-session-response-on-password-entry
branch
from
ddabacd
to
23d94f5
Compare
|
mattvot
approved these changes
Sep 18, 2024
BeckaL
deleted the
AUT-3725/return-error-for-no-session-response-on-password-entry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…issing or invalid session
This error response means that we cannot continue. However, at the moment we fall through to the default error behaviour, which is to reload the page with a validation error, making it seem like the user entered the incorrect password.
This handles an edge case in reauthentication whereby the user is logged in in two tabs, starts a reauth journey in another up until the point of entering a password, and then logs out in the first tab. At this point, they will enter an infinite loop of seeming password validation errors regardless of password, whereas in fact the backend is totally unable to proceed.
It's also possible to replicate this in the signin journey, although you have to be very specific with timings.
Currently, redirecting to the error page will return a 500 status. This particular case (a user has logged off) does not actually indicate a server error. We can choose to update this later if this causes an issue.
How to review
Deploy to a test environment and:
You can compare to the behaviour in staging.