Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ DO NOT APPROVE: AUT-3665: Demonstrate shared pages approach. #2037

Closed

Conversation

gtvj
Copy link
Collaborator

@gtvj gtvj commented Sep 10, 2024

What

Shows how approach 2 might be implemented. This is achieved by:

  • Introducing a mobile specific layout (See commit 4c05d3b)
  • Adding content to translation files for the mobile state (See commit 57f9d6f)
  • Supplying a 'mobileContext` variable to the view. This will be used by conditions in the template (See commit ffffc53)
  • Updating the existing template to include conditions so that only the mobile content will be shown where mobileContext === true (See commit f66219b)

I've also added an additional commit to break the unit tests (just as an extra precaution should this accidentally be approved and merged somehow).

This layout will be used by templates that are intended
for presentation within a mobile app. It differs from the
web template because:

- It does not have the header as a link
- It does not have a footer (reflecting the designs for the
  landing page which are included in the Jira ticket).
This will be used within template conditions
@gtvj gtvj requested review from a team as code owners September 10, 2024 15:02
Copy link

sonarcloud bot commented Sep 10, 2024

@gtvj gtvj closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant