Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUT-3613: Log a reauth user out if they are blocked for reauth #2014

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

BeckaL
Copy link
Contributor

@BeckaL BeckaL commented Sep 3, 2024

This ensures that a user who has exceeded the max tries for credential entry on reauth cannot start a new reauth journey - if the start response indicates that a user has any blocks, they will be logged out rather than allowed to proceed with a reauth journey

How to review

  1. Code Review
  2. Deploy to authdev1 with the relevant backend (main) deployed
  3. Open two different browsers. Log in in both
  4. Start a reauth journey in one. Enter the wrong email or the wrong password to the point where you're logged out
  5. Start a reauth journey in your other browser. Note that you are immediately logged out

## Related PRs:

Backend PR that started returning this information from the start response: govuk-one-login/authentication-api#5152

This ensures that a user who has exceeded the max tries for credential entry on reauth cannot start a new reauth journey - if the start response indicates that a user has any blocks, they will be logged out rather than allowed to proceed with a reauth journey
@BeckaL BeckaL requested review from a team as code owners September 3, 2024 14:10
Copy link

sonarcloud bot commented Sep 3, 2024

@BeckaL BeckaL merged commit 8e56bbe into main Sep 3, 2024
7 checks passed
@BeckaL BeckaL deleted the AUT-3613/logout-user-if-start-says-reauth-blocked branch September 3, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants