AUT-3407: Add spinner dependency #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary so that the script can be available to HTML pages requesting it.
gtvj
force-pushed
the
AUT-3407/add-spinner-dependency-and-enable-for-testing
branch
5 times, most recently
from
d83fa6f
to
6795199
Compare
Necessary to address issued identified by SonarCloud (that have come to light when amending the file).
gtvj
force-pushed
the
AUT-3407/add-spinner-dependency-and-enable-for-testing
branch
from
6795199
to
6e3fa12
Compare
Reformatting was necessary because changes to application.scss caused the GitHub pre-commit step to fail
gtvj
force-pushed
the
AUT-3407/add-spinner-dependency-and-enable-for-testing
branch
from
77a353d
to
975d372
Compare
This is so that the styles for the spinner will be included in the distributed CSS.
gtvj
force-pushed
the
AUT-3407/add-spinner-dependency-and-enable-for-testing
branch
from
975d372
to
e3d125b
Compare
|
gtvj
changed the title
andrew-moores
approved these changes
Aug 15, 2024
gtvj
deleted the
AUT-3407/add-spinner-dependency-and-enable-for-testing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds JavaScript and Sass to enable the new spinner. This includes:
copy-assetstask to bringspinner-app.jsacross the thescriptsdirectoryapplication.sassfor inclusion in bundled CSS.Once merged the spinner page will be enabled in environments where the feature flag is enabled, allowing for testing in
staging.How to review
Code Review commit-by-commit. Two commits are prefixed with "BAU" because they relate to a formatting change.
Related PRs