Aut-3046: add reauth max codes sent scenario into resent email code c… #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/resend-email-code/tests/resend-email-code-controller.test.ts
Outdated
Show resolved
Hide resolved
andrew-moores
force-pushed
the
aut-3046-reauth-sms-code
branch
2 times, most recently
from
10cb087
to
1d9f235
Compare
andrew-moores
force-pushed
the
aut-3046-reauth-sms-code
branch
8 times, most recently
from
ea01ed4
to
5bcdeec
Compare
…t when re-authentication is supported. Add reauth max codes sent scenario into resent email code controller. Improving the tests. Introduced new test values in common-test-variables. Improved the names of some of the variables to better describe their purpose.
…lly. Made all the integration tests fully async with all the requests being awaited. Started to tidy up the process.env environment variables as some tests were setting them and not resetting them back to a default which was causing subsequent tests to fail.
…rrors Removed the return statement from the error handler in send-mfa-controller as the handler should only set the redirect path and allow the error to be passed back to express when the BadRequestException is thrown. Moved the pageNotFoundHandler above the error handlers to make it clear that this is not an error handler. Added a comment to reinforce the fact that there are only two error handlers. Updated tests to reflect these changes.
andrew-moores
force-pushed
the
aut-3046-reauth-sms-code
branch
from
5bcdeec
to
92afd89
Compare
|
BeckaL
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Redirect the User back to the RP in a logged out state after they exceed the maximum number of re-requests of SMS security codes when trying to reset their password after starting a re-authentication journey.
Updated controller to redirect to orchestration with path parameters that indicate the User should be logged out. The User is not logged out.
The integration tests were changed to make await async calls to allow them to be run reliably locally.
How to review
Checklist
Related PRs