Merge pull request #1898 from govuk-one-login/AUT-2932/release-email-…

…checks AUT-2932: Enable email address checks
govuk-one-login · Aug 5, 2024 · d4e39f8 · d4e39f8
2 parents 78dae4c + bc91000
commit d4e39f8
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 16 deletions.
diff --git a/ci/terraform/authdev1.tfvars b/ci/terraform/authdev1.tfvars
@@ -16,7 +16,6 @@ support_account_interventions                       = "1"
 support_reauthentication                            = "1"
 support_2fa_b4_password_reset                       = "1"
 support_2hr_lockout                                 = "1"
-support_check_email_fraud                           = "1"
 password_reset_code_entered_wrong_blocked_minutes   = "1"
 account_recovery_code_entered_wrong_blocked_minutes = "1"
 code_request_blocked_minutes                        = "1"

diff --git a/ci/terraform/authdev2.tfvars b/ci/terraform/authdev2.tfvars
@@ -20,7 +20,6 @@ support_account_interventions                       = "1"
 support_reauthentication                            = "1"
 support_2fa_b4_password_reset                       = "1"
 support_2hr_lockout                                 = "1"
-support_check_email_fraud                           = "1"
 password_reset_code_entered_wrong_blocked_minutes   = "1"
 account_recovery_code_entered_wrong_blocked_minutes = "1"
 code_request_blocked_minutes                        = "1"

diff --git a/ci/terraform/build.tfvars b/ci/terraform/build.tfvars
@@ -17,7 +17,6 @@ support_account_interventions                       = "1"
 support_reauthentication                            = "0"
 support_2fa_b4_password_reset                       = "1"
 support_2hr_lockout                                 = "1"
-support_check_email_fraud                           = "1"
 password_reset_code_entered_wrong_blocked_minutes   = "1"
 account_recovery_code_entered_wrong_blocked_minutes = "1"
 code_request_blocked_minutes                        = "1"

diff --git a/ci/terraform/sandpit.tfvars b/ci/terraform/sandpit.tfvars
@@ -17,7 +17,6 @@ support_account_interventions                       = "1"
 support_reauthentication                            = "1"
 support_2fa_b4_password_reset                       = "1"
 support_2hr_lockout                                 = "1"
-support_check_email_fraud                           = "1"
 password_reset_code_entered_wrong_blocked_minutes   = "1"
 account_recovery_code_entered_wrong_blocked_minutes = "1"
 code_request_blocked_minutes                        = "1"

diff --git a/ci/terraform/staging.tfvars b/ci/terraform/staging.tfvars
@@ -18,7 +18,6 @@ support_account_interventions                       = "1"
 support_authorize_controller                        = "1"
 support_2fa_b4_password_reset                       = "1"
 support_2hr_lockout                                 = "1"
-support_check_email_fraud                           = "1"
 code_request_blocked_minutes                        = "120"
 account_recovery_code_entered_wrong_blocked_minutes = "120"
 code_entered_wrong_blocked_minutes                  = "120"

diff --git a/ci/terraform/variables.tf b/ci/terraform/variables.tf
@@ -269,7 +269,7 @@ variable "support_reauthentication" {
 variable "support_check_email_fraud" {
   description = "When true enables Fraudulent email checking via Experian lockout"
   type        = string
-  default     = "0"
+  default     = "1"
 }
 
 variable "prove_identity_welcome_enabled" {

diff --git a/src/components/check-your-email/check-your-email-controller.ts b/src/components/check-your-email/check-your-email-controller.ts
@@ -70,17 +70,21 @@ export const checkYourEmailPost = (
     }
     if (supportCheckEmailFraud()) {
       const { sessionId, clientSessionId, persistentSessionId } = res.locals;
-      const checkEmailFraudResponse =
-        await checkEmailFraudService.checkEmailFraudBlock(
-          req.session.user.email,
-          sessionId,
-          clientSessionId,
-          persistentSessionId,
-          req
+      try {
+        const checkEmailFraudResponse =
+          await checkEmailFraudService.checkEmailFraudBlock(
+            req.session.user.email,
+            sessionId,
+            clientSessionId,
+            persistentSessionId,
+            req
+          );
+        logger.info(
+          `checkEmailFraudResponse: ${checkEmailFraudResponse.data.isBlockedStatus}`
         );
-      logger.info(
-        `checkEmailFraudResponse: ${checkEmailFraudResponse.data.isBlockedStatus}`
-      );
+      } catch (e) {
+        logger.error("Error checking email fraud block", e);
+      }
     }
     const verifyCodeRequest = verifyCodePost(
       service,