Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

Commit

Permalink
[HTML report] Fixed highlight of conditional expressions
Browse files Browse the repository at this point in the history
There is a problem with processing conditional expressions (such as: a ? b : c). They were highlighted till end of file, to fix this
I corrected line 296 - it was a misstype endCol -> endLine and added 'cond-expr' type of branch to special highlight.
  • Loading branch information
Indomian authored Apr 26, 2017
1 parent 89e338f commit 3b4817c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/report/html.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,14 +286,14 @@ function annotateBranches(fileCoverage, structuredText) {
endCol = structuredText[startLine].text.originalLength();
}
text = structuredText[startLine].text;
if (branchMeta[branchName].type === 'if') { // and 'if' is a special case since the else branch might not be visible, being non-existent
if (branchMeta[branchName].type === 'if' || branchMeta[branchName].type === 'cond-expr') { // and 'if' is a special case since the else branch might not be visible, being non-existent
text.insertAt(startCol, lt + 'span class="' + (meta.skip ? 'skip-if-branch' : 'missing-if-branch') + '"' +
title((i === 0 ? 'if' : 'else') + ' path not taken') + gt +
(i === 0 ? 'I' : 'E') + lt + '/span' + gt, true, false);
(i === 0 ? 'I' : 'E') + lt + '/span' + gt, true, false);
} else {
text.wrap(startCol,
openSpan,
startLine === endLine ? endCol : text.originalLength(),
startLine === endLine ? endLine : text.originalLength(),
closeSpan);
}
}
Expand Down

0 comments on commit 3b4817c

Please sign in to comment.