fix: generate correct filenames when series name or book filename contain UTF-8 #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give some context or explain when/how it's a problem? |
|
Japanese series names, when downloading the full series, have the filename set as ________________.zip, and when downloading an individual file that has any Japanese character in the name, has the filename set as "file.zip" rather than whatever the filename was on disk. |
|
Thanks @awh-tokyo ! |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
## [0.157.1](v0.157.0...v0.157.1) (2022-08-18) ### Bug Fixes * **api:** prevent SQLITE_TOOBIG book search returns many matches ([f8cc3cd](f8cc3cd)), closes [#940](#940) * encode filenames in UTF-8 when downloading ([#941](#941)) ([cf98e69](cf98e69)) * translated using Weblate ([c85f267](c85f267)) * **webui:** iOS icon without black edges ([#949](#949)) ([a3929e2](a3929e2)) * **webui:** search for collection/readlist in the "add to" dialog should ignore accents ([ac67924](ac67924)), closes [#944](#944)
|
🎉 This PR is included in version 0.157.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.