Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnail not properly generating from PNG images #976

Closed
5 tasks done
PenDrag0n7 opened this issue Sep 20, 2022 · 2 comments
Closed
5 tasks done

Thumbnail not properly generating from PNG images #976

PenDrag0n7 opened this issue Sep 20, 2022 · 2 comments
Assignees
@gotson
Labels
bug Something isn't working released

Comments

@PenDrag0n7
Copy link

PenDrag0n7 commented Sep 20, 2022 •
edited
Loading

Steps to reproduce

Ran into an issue with some png images.
which aren't getting their thumbnail generated correctly

I have provided 2 samples images in zip files,
Sample_2.zip
Sample_1.zip

Expected behavior

The thumbnail should have been created without distortion.

Actual behavior

Thumbnails are distorted
Sample 1: image has a blue tint vs Sample 3 which is the same image converted to JPEG
Sample 2: Image has missing detail (PNG4 with missing color channels)
image

Logs

No response

Komga version

v0.157.1

Operating system

Docker (linux)

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have checked the FAQ.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@gotson
Copy link
Owner

gotson commented Sep 20, 2022

Thumbnail depends on 3rd party libraries for thumbnail generation and also for image readers.

@gotson gotson mentioned this issue Sep 20, 2022
Closed
@gotson gotson added bug Something isn't working blocked Blocked by another issue dependencies Related to project dependencies labels Sep 20, 2022
@gotson gotson removed dependencies Related to project dependencies blocked Blocked by another issue labels Oct 24, 2022
@gotson gotson self-assigned this Oct 24, 2022
gotson added a commit that referenced this issue Oct 24, 2022
@gotson
fix: set image type when generating thumbnails to avoid missing channels
19813af 
Closes: #976
@gotson gotson closed this as completed in 40f3e16 Oct 30, 2022
github-actions bot pushed a commit that referenced this issue Nov 2, 2022
@semantic-release-bot
chore(release): 0.157.4 [skip ci]
8125ada 
## [0.157.4](v0.157.3...v0.157.4) (2022-11-02)

### Bug Fixes

* set image type when generating thumbnails to avoid missing channels ([40f3e16](40f3e16)), closes [#976](#976)

### Performance Improvements

* optimize task FindDuplicatePagesToDelete ([59a0048](59a0048))
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

🎉 This issue has been resolved in version 0.157.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gotson gotson

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gotson @PenDrag0n7