Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Align Double Pages According to their Reading Direction #670

Closed
kanjieater opened this issue Sep 12, 2021 · 4 comments
Closed
Labels
enhancement New feature or request reader:divina Need works in the WebReader released

Comments

@kanjieater
Copy link

Is your feature request related to a problem? Please describe.

I read comic with double pages on two vertical monitors.

When in double page mode, Komga centers single pages.
image

Double pages still look fine:
image

It also doesn't put the second to last page and the last page next to each other. This part may be considered a bug.

Second to last page:
image

Last page:
image

Describe the solution you'd like

Show right to left pages aligned to the left if it's at the beginning & left to right pages at the left if it's at the beginning.

Short right to left pages aligned to the right if it's at the end, and show left to right pages the right if it's at the end.

This should fix the natural flow of the pages.

Describe alternatives you've considered or other apps that can do what you want

Cover does exactly this:
Right to left, first page, left aligned
image
Last two pages:
image

Additional context

This is a comic that is available freely online that you can try it out with to reproduce: https://www.dropbox.com/s/9t0khm18ivwnr09/%E9%AD%94%E5%A5%B3%E3%81%A8%E9%A8%8E%E5%A3%AB%E3%81%AF%E7%94%9F%E3%81%8D%E3%81%AE%E3%81%93%E3%82%8B%20-%20%E7%AC%AC01%E5%B7%BB.cbz?dl=0

@gotson gotson added consider Not sure yet if this makes sense or not reader:divina Need works in the WebReader labels Sep 12, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 12, 2021
@kanjieater
Copy link
Author

still interested

@github-actions github-actions bot removed the stale label Dec 14, 2021
@gotson gotson added enhancement New feature or request and removed consider Not sure yet if this makes sense or not labels Dec 14, 2021
@gotson gotson closed this as completed in 218fd79 Dec 14, 2021
@gotson
Copy link
Owner

gotson commented Dec 14, 2021

For this to work best, pages must have been analyzed for dimensions (which is the default since quite some time) . If it's not the case, an arbitrary aspect ratio is used instead, which should work fine for most images.

Reanalyzing the book will get the correct dimensions in case you're not happy with the default alignment.

github-actions bot pushed a commit that referenced this issue Dec 14, 2021
# [0.136.0](v0.135.1...v0.136.0) (2021-12-14)

### Features

* **webreader:** align double pages according to reading direction ([218fd79](218fd79)), closes [#670](#670)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.136.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request reader:divina Need works in the WebReader released
Projects
None yet
Development

No branches or pull requests

2 participants