Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker for Release Date shows wrong First day of week #1113

Closed
5 tasks done
PhilippKammann opened this issue Apr 24, 2023 · 4 comments
Closed
5 tasks done

Datepicker for Release Date shows wrong First day of week #1113

PhilippKammann opened this issue Apr 24, 2023 · 4 comments
Labels
bug Something isn't working released WebUI Need works in the WebUI

Comments

@PhilippKammann
Copy link

Steps to reproduce

  1. Edit Book Metadata
  2. Click on "Release Date" field and open Datepicker

Expected behavior

Datepicker opens with locale First day of week (Monday in my case as my whole system is set to German/Germany)

Actual behavior

Datepicker opens with First day of week as Sunday

Logs

No response

Komga version

v0.165.0

Operating system

Docker

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have checked the FAQ.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@gotson gotson added bug Something isn't working WebUI Need works in the WebUI and removed triage labels Apr 25, 2023
gotson added a commit that referenced this issue Jun 27, 2023
@gotson
fix(webui): apply chosen locale to the date picker dialog
1428c39 
Closes: #1113
@gotson gotson closed this as completed in 7b3534a Jun 28, 2023
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in v1.0.0 (Release Notes)

@gotson gotson mentioned this issue Jun 28, 2023
Closed
5 tasks
@gotson
Copy link
Owner

gotson commented Jun 29, 2023

@PhilippKammann sadly this doesn't work on Firefox yet: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/getWeekInfo#browser_compatibility

@PhilippKammann
Copy link
Author

Works for me in Firefox
grafik

@gotson
Copy link
Owner

gotson commented Jul 1, 2023

Works for me in Firefox grafik

Because it defaults to Monday if it can't find the week info from the locale.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working released WebUI Need works in the WebUI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gotson @PhilippKammann