-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPDS] Image link should return full-sized custom thumbnail if set #1099
Comments
The links will not change, however the content returned by the image/thumbnail link changes. I just tried and it works as expected. Are you testing via an OPDS client, or directly via the browser ? |
I'm testing via a browser, but I tried clearing the cache and then using a different browser entirely so I don't think it's a caching issue. The "image/thumbnail" contents do change when I upload a custom cover, though the returned image seems to be full-resolution for me, not a smaller version. That may be by design. However, the "image" link remains a link to the first page of the book which still shows the original artwork:
My expectation would have been that the "image" link would return the full-size poster image (either page 1 of the book, or whatever the user has uploaded through the edit book dialog), and the "image/thumbnail" would return a lower-resolution version of the same image. |
I finally understood what you meant, sorry about that. The spec says:
The spec is vague enough so that whatever image could be used. However, the Which is not what is happening now. So it could go one of 2 ways:
Point 2 is what you suggest, however i can't remember whether Komga keeps the full size image in various cases. In addition, the thumbnail endpoint for custom poster returns the full size of that image. It works for generated thumbnails because they have been resized already, but not for custom covers. |
🎉 This issue has been resolved in |
Steps to reproduce
Expected behavior
The "image" link should be the original image uploaded as the custom poster, and the "image/thumbnail" link should be a thumbnail version of the same image.
Actual behavior
Although the "image/thumbnail" link contents have changed, it's a full-size image, not a thumbnail, and the "image" link is still the first page of the book.
Logs
No response
Komga version
0.163.0
Operating system
Linux, running the docker image
Other details
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: