Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow text entry for release date in book's edit dialog in addition to the date picker #1097

Closed
4 tasks done
gsargent70 opened this issue Mar 17, 2023 · 7 comments
Closed
4 tasks done
Labels
enhancement New feature or request released WebUI Need works in the WebUI

Comments

@gsargent70
Copy link

Describe your suggested feature

The new date picker feature is great but for those of us who use the keyboard mostly it now takes longer to enter a date utilizing the mouse and mouse clicks. Could we have a feature added to turn the date picker on/off in the settings that way you can use the old way or the new date picker according to the end users workflow preference?

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@gotson gotson added wontfix This will not be worked on and removed triage labels Mar 18, 2023
@gotson
Copy link
Owner

gotson commented Mar 18, 2023

If every time we add a feature, there's a toggle to remove it, that's not gonna work.

@kiriya-aoi
Copy link

Having an icon in the Release Date field that opened a date picker while leaving typed entry possible would be okay too for quick addition of a date here and there.

It looks like typed entry is still possible in "Bulk edit metadata" operation regardless, which is the bulk of my use case so as long as that is preserved I'm not overly concerned.

@Kussie
Copy link
Contributor

Kussie commented Mar 18, 2023

I have to agee with the others, I loathe any non native date picker and find them much much slower. Maintaining the ability to type the date would be ideal. Be it making the selection via the picker optional (it can still pop up and the user can either use it or not) or opening it via an icon would be ideal and both of these approaches are fairly standard.

@gotson
Copy link
Owner

gotson commented Mar 18, 2023

Maintaining the ability to type the date would be ideal.

Seems possible. The text field is read-only to prevent the keyboard from popping up on mobile. We could imagine setting read-only only for xs size screens, as inputting a date on a mobile device in a text field would be painful anyway. Or just leave it editable in all sizes.

@Kussie
Copy link
Contributor

Kussie commented Mar 18, 2023

You could be really clever and if it's a mobile device, set the field to be a type of 'date' so it will use the native mobile date picker, and the popup date picker only shows on non mobile, which means the field wouldn't need to be readonly and get the best of both worlds

@gsargent70
Copy link
Author

Yea any of the above ideas would be great. I am just for having options in terms of data entry as not everyone will have the same workflows.

@gotson gotson changed the title Ability to select graphical Date Picker on or off in settings allow text entry for release date in book's edit dialog in addition to the date picker Mar 20, 2023
@gotson gotson added enhancement New feature or request WebUI Need works in the WebUI and removed wontfix This will not be worked on labels Mar 20, 2023
gotson added a commit that referenced this issue Jun 27, 2023
@gotson gotson closed this as completed in 902f700 Jun 28, 2023
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in v1.0.0 (Release Notes)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released WebUI Need works in the WebUI
Projects
None yet
Development

No branches or pull requests

4 participants