No graceful shutdown when connected to website

[lambdareader]

Steps to reproduce

1: log-in on website
2: shut down server via SIGTERM or SIGINT

Expected behavior

graceful shutdown even with active requests perhaps?

Actual behavior

graceful shutdown aborted

Logs

2022-12-27 16:52:56.921  INFO 25786 --- [SpringApplicationShutdownHook] o.s.b.w.e.tomcat.GracefulShutdown        : Commencing graceful shutdown. Waiting for active requests to complete
2022-12-27 16:53:26.926  INFO 25786 --- [SpringApplicationShutdownHook] o.s.c.support.DefaultLifecycleProcessor  : Failed to shut down 1 bean with phase value 2147483647 within timeout of 30000ms: [webServerGracefulShutdown]
2022-12-27 16:53:26.969  INFO 25786 --- [tomcat-shutdown] o.s.b.w.e.tomcat.GracefulShutdown        : Graceful shutdown aborted with one or more requests still active
2022-12-27 16:53:28.949  INFO 25786 --- [SpringApplicationShutdownHook] io.hawt.web.auth.AuthenticationFilter    : Destroying hawtio authentication filter
2022-12-27 16:53:28.951  INFO 25786 --- [SpringApplicationShutdownHook] io.hawt.HawtioContextListener            : Destroying hawtio services
2022-12-27 16:53:29.321  INFO 25786 --- [SpringApplicationShutdownHook] org.apache.activemq.artemis.core.server  : AMQ221002: Apache ActiveMQ Artemis Message Broker version 2.19.1 [e181f9df-756d-11ed-84c0-dca63217cef3] stopped, uptime 2 minutes
2022-12-27 16:53:29.330  INFO 25786 --- [SpringApplicationShutdownHook] com.zaxxer.hikari.HikariDataSource       : SqliteUdfPool - Shutdown initiated...
2022-12-27 16:53:29.338  INFO 25786 --- [SpringApplicationShutdownHook] com.zaxxer.hikari.HikariDataSource       : SqliteUdfPool - Shutdown completed.

Komga version

v0.157.5

Operating system

Linux

Other details

I am not too sure if it is a problem at all. Most likely it isn't just wanted to know if it is intended behavior or if it causes any kind of issues.

Additionally could a SIGKILL / forceful server shutdown / power outage mid scan corrupt the database? Should I keep versioned backups?

Acknowledgements

• I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
• I have written a short but informative title.
• I have checked the FAQ.
• I have updated the app to the latest version.
• I will fill out all of the requested information in this form.

[gotson]

I don't understand what's your issue? The server stopped according to the logs.

[gotson]

I checked this, and SEE connections are not getting closed during the graceful shutdown phase. Other connections would still terminate gracefully, but if a browser session is open then the graceful shutdown would always timeout after the default 30s.

[github-actions]

🎉 This issue has been resolved in version 0.158.0 🎉

The release is available on:

• v0.158.0
• GitHub release

Your semantic-release bot 📦🚀