Fix sidebar height & hide ScrollUpButton until scrolled (fade in) #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gotify#383 and issue found within gotify#276
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 44 44
Lines 1436 1436
=======================================
Hits 1277 1277
Misses 85 85
Partials 74 74 Continue to review full report at Codecov.
|
jmattheis
requested changes
Jan 22, 2021
jmattheis
reviewed
Jan 22, 2021
|
Feedback implemented @jmattheis |
jmattheis
reviewed
Jan 24, 2021
ui/src/common/ScrollUpButton.tsx
Outdated
|
|
||
| componentWillUnmount() { | ||
| if (typeof window !== 'undefined') { | ||
| window.removeEventListener('scroll', this.scrollHandler.bind(this)); |
There was a problem hiding this comment.
I think this doesn't work as .bind will give a new reference and thus, doesn't unregister the old handler. I'll fix this. Also, I'll prevent some rerenders, by checking if the state will be changed.
jmattheis
force-pushed
the
sidebar_jump_top
branch
from
cb8e3f7
to
29a0171
Compare
jmattheis
approved these changes
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383 and issue found within #276