Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async borrowing (continuation of #449) #450

Merged
merged 15 commits into from
Sep 5, 2020
Merged

Async borrowing (continuation of #449) #450

merged 15 commits into from
Sep 5, 2020

Commits on Aug 28, 2020

  1. WIP: "closure implements Fn, so references to captured variables ca… 

    …n't escape the closure"
    @alsuren @tanriol
    alsuren authored and tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    94fa599 View commit details
    Browse the repository at this point in the history

  2. to_async_borrowing: pass state by a mutable ref 

    This change is important for two reasons. First, it allows the async
handler to take the body (or other data) from State. Second, a mutable
reference, unlike a shared one, can be Send without State being Sync
(which it is not).
    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    8bb7dac View commit details
    Browse the repository at this point in the history

  3. to_async_borrowing: move captures into the async block

    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    a36cd23 View commit details
    Browse the repository at this point in the history

  4. builder: rename FnHelper to AsyncHandlerFn and make pub

    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    7dafd8f View commit details
    Browse the repository at this point in the history

  5. AsyncHandlerFn: drop unneeded bounds 

    These are required on the handler factory (NewHandler impl), but not on
the handler itself.
    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    dc6e030 View commit details
    Browse the repository at this point in the history

  6. AsyncHandlerFn: rename type parameter to Fut

    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    335cde5 View commit details
    Browse the repository at this point in the history

  7. handler: add a SimpleHandlerResult type alias

    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    4a696fe View commit details
    Browse the repository at this point in the history

  8. to_async_borrowing: make return type generic 

    The success path can return not only a response but also anything that
implements IntoResponse.
    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    6657ecd View commit details
    Browse the repository at this point in the history

  9. to_async_borrowing: move out impl from definition 

    Split the impl into the new handler marker trait
and the actual impl using it.
    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    ea29f92 View commit details
    Browse the repository at this point in the history

  10. to_async_borrowed: add examples to docs

    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    25af37c View commit details
    Browse the repository at this point in the history

  11. DEMO: port simple_async_handlers_await example

    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    5f6e044 View commit details
    Browse the repository at this point in the history

  12. simple_async_handlers_await: update comments

    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    ac424d9 View commit details
    Browse the repository at this point in the history

  13. DEMO: use generic return type in the example

    @tanriol
    tanriol committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    73f4ed1 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. to_async_borrowing: expand docs and example

    @tanriol
    tanriol committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    9a08d71 View commit details
    Browse the repository at this point in the history

  2. examples: have both to_async and to_async_borrowing 

    This partially reverts 5f6e044 and 73f4ed1.
    @tanriol
    tanriol committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    f853599 View commit details
    Browse the repository at this point in the history