Switch to rustfmt shipped in stable for CI#197
Merged
smangelsdorf merged 2 commits intomasterfrom Apr 3, 2018
Merged
Conversation
This seems practical now that 0.3.8 is shipping in Rust 1.25.
Contributor
Author
|
Seems to have the desire/expected outcome: https://travis-ci.org/gotham-rs/gotham/jobs/360532848 |
smangelsdorf
reviewed
Apr 1, 2018
| before_script: | ||
| - rustup toolchain install nightly | ||
| - rustup component add --toolchain nightly rustfmt-preview | ||
| - rustup component add --toolchain stable rustfmt-preview |
Contributor
There was a problem hiding this comment.
L33 here should be updated too, shouldn't it?
Picked up through PR comment, we rightly don't need to install toolchain for nightly any longer.
Contributor
Author
smangelsdorf
approved these changes
Apr 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems practical now that 0.3.8 is shipping in Rust 1.25.