Correctly specify minimum dependency versions#185
Merged
bradleybeddoes merged 3 commits into0.2-maintfrom Mar 18, 2018
Merged
Conversation
There are cases where gotham (and by extension, gotham apps) won't build correctly with the currently specified minimum version. Specifying the minimum version which permits gotham to build correctly ensures that it can't be broken by apps with old `Cargo.lock` files. Fixes #180
Right now, 3 shards separately spend ~10 minutes building a release version of rustfmt from source so that they can perform the same <1s check over the same source code. Instead, one shard will compile and run rustfmt, while the other 3 will just run the tests. rustfmt passing with a stable `cargo` version should be sufficient. This should speed up travis, perform less redundant work, and make test shards less likely to timeout.
This regresses us to a more official release (0.3.8 rather than 0.4.0) but saves 8~10 minutes of compiling rustfmt from scratch.
| log = "0.4" | ||
| hyper = { version = "0.11", features = [] } | ||
| log = "0.4.1" | ||
| hyper = { version = "0.11.7", features = [] } |
Contributor
There was a problem hiding this comment.
epic nit, ignorable.
Given we're not using any hyper features should we take the opportunity to revert back to hyper = "0.11.7" format?
Contributor
Author
There was a problem hiding this comment.
I thought the goal here was to explicitly opt out of hyper's default features. From looking at the latest hyper, that seems to opt us out of tokio-proto compatibility (since we don't need it). I might be misreading though.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where Gotham (and by extension, Gotham apps) won't build correctly with the currently specified minimum version. Specifying the minimum version which permits Gotham to build correctly ensures that it can't be broken by apps with old
Cargo.lockfiles.Fixes #180
This also brings the Travis CI changes from #173 and #174 into the 0.2-maint branch.