Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action for notifiying of missing email in AUTHOR file #288

Merged
merged 3 commits into from
Dec 2, 2023

Conversation

jaytaph
Copy link
Member

@jaytaph jaytaph commented Nov 30, 2023

Does the following:

  • fetches the first 10 committers in the diff and checks if either their name or email (or both) are found in the AUTHORS file.
  • if not, it will post a comment saying the user is invited to add their name(s).
  • if found (during a new commit after the first one), and the names are found, the comment is automatically removed.

Copy link
Member

@Sharktheone Sharktheone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sharktheone
Copy link
Member

It might make sense to rename this PR

@jaytaph
Copy link
Member Author

jaytaph commented Nov 30, 2023

don't worry.. just testing some things out on github actions... always trail and error... will ping when this is finalized (and rebased)

@jaytaph jaytaph changed the title initial setup Github action for notifiying of missing email in AUTHOR file Nov 30, 2023
Copy link
Member

@Sharktheone Sharktheone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, change it so, that it doesn't post multiple times. Besides that looks good.

@gosub-io gosub-io deleted a comment from github-actions bot Dec 1, 2023
@gosub-io gosub-io deleted a comment from github-actions bot Dec 1, 2023
@Sharktheone
Copy link
Member

Sharktheone commented Dec 1, 2023

Not sure, how we want to handle this, but for example my name isn't in my commits nor on my GH Profile. When the person decides, to not have their email but the real name in the AUTHORS file, we can't know who it is. I guess, this is an edge case we need to manually Prevent. Maybe it is possible then to write the gh name in the <>s.

Copy link
Collaborator

@emwalker emwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions. LGTM.

.github/workflows/check_authors.sh Outdated Show resolved Hide resolved
.github/workflows/check_authors.sh Outdated Show resolved Hide resolved
@jaytaph jaytaph merged commit 608003a into main Dec 2, 2023
5 checks passed
@jaytaph jaytaph deleted the author-action branch December 2, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants