-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github action for notifiying of missing email in AUTHOR file #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It might make sense to rename this PR |
don't worry.. just testing some things out on github actions... always trail and error... will ping when this is finalized (and rebased) |
8506cfe
to
ec6943e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, change it so, that it doesn't post multiple times. Besides that looks good.
7609506
to
70e7447
Compare
Not sure, how we want to handle this, but for example my name isn't in my commits nor on my GH Profile. When the person decides, to not have their email but the real name in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestions. LGTM.
Co-authored-by: Eric Walker <[email protected]>
Co-authored-by: Eric Walker <[email protected]>
Does the following: