fix(state): reset the CurrentHostIP on closed iscsi connection #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: prateekpandey14 <[email protected]>
|
LGTM, thanks |
|
Thanks @carmark for quick reviews and merge. Can you pls create a new tag with this changes. |
|
Sure, no prolem. @prateekpandey14 |
|
done, please try it. @prateekpandey14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prateekpandey14 [email protected]
PR tries to fix the issue with iscsi connection, in case k8s Node is shutdown abruptly, ending up not allowing the reschedule application pod to mount the volume again.
PR reset the CurrentHostIP in case of connection state is closed and set the state as closed in case of any readdata errors happens on IOSTATE_RX_BHS state.
More info: openebs-archive/jiva-operator#125