Skip to content

fix: stack overflow #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zchee merged 3 commits into from
Sep 28, 2025
Merged

fix: stack overflow #21

zchee merged 3 commits into from
Sep 28, 2025

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Sep 4, 2025 •
edited by zchee
Loading

Fixes #20
Fixes #15

@zchee edited:
golangci-lint ref: golangci/golangci-lint#6087

@ldez ldez mentioned this pull request Sep 4, 2025
Closed
7 tasks
@ldez ldez force-pushed the fix/update-x-tools branch from bc6b593 to 63be8d6 Compare September 11, 2025 14:25
@ldez ldez mentioned this pull request Sep 18, 2025
Merged
@zchee zchee requested review from tenntenn and zchee September 24, 2025 11:52
@zchee
Copy link
Member

zchee commented Sep 24, 2025

cc: @tenntenn

@zchee
Copy link
Member

zchee commented Sep 24, 2025 •
edited
Loading

@ldez Thanks for the PR! I was reproduced.
For future maintenance, could you please add a comment explaining why you are using seen and skipping with the continue directive in getValueLineNumbers?

zchee
zchee reviewed Sep 24, 2025
View reviewed changes
Copy link
Member

@zchee zchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I want to wait for @tenntenn reaction🙏

@zchee
Copy link
Member

zchee commented Sep 24, 2025

And, @alexandear thanks for ping :)

@zchee zchee merged commit 3c6b352 into gostaticanalysis:master Sep 28, 2025
@zchee
Copy link
Member

zchee commented Sep 28, 2025

@ldez Thanks! Merged and cut new release:

@ldez ldez deleted the fix/update-x-tools branch September 28, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zchee zchee zchee left review comments

@tenntenn tenntenn Awaiting requested review from tenntenn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: fatal error: stack overflow Bump golang.org/x/tools to v0.7.0 (as minimum) and make new tag

2 participants

@ldez @zchee