-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure for re-usability and concurrency #51
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 84 83 -1
=========================================
- Hits 84 83 -1
Continue to review full report at Codecov.
|
This patch would support closing argoproj/argo-cd#18369. It's been some time since it was open. Is it worth re-evaluating, or is there an alternate solution? |
Hello, I forgot about this. It's been a while! I still think it would be a good addition worth re-evaluating. It should be updated though, as some options are missing from my PR. |
Hello, yeah, it would be good to get this functionality. I also see this PR: #41 that attempts the same goal. I see @matrixik as the primary reviewer and feedback provider for the recent PRs. Maybe he could provide some guidance on how to get the ball rolling again. It probably won't make sense to update both PRs. |
Description
Create a structure and make it implement the slug functions.
Benefits:
Drawback:
Example usage
Notes
This change is not breaking.
Similar to #41