Drop accept-encoding header when supported #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 13, 2019 14:34
This prevents following handlers from encoding the request again since we dropped the intention to do this. Fixes gorilla#153
|
The CI run failed because I used subtests which are not available for Go <1.7 😑 |
|
Should I squash my commits? |
|
I can squash on merge.
You can require >= 1.7 - remove older versions from TravisCI.
…On Mon, Apr 15, 2019 at 12:16 PM Andreas Linz ***@***.***> wrote:
Should I squash my commits?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#157 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABIcNw7Jy6Cd8xFv5KFNMWVc9gE7jltks5vhENOgaJpZM4cuFKt>
.
|
|
Any news on this? |
|
@elithrar this is still relevant. Any news? |
|
Thanks for this, @klingtnet! (been swamped!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents following handlers from encoding the request again since
we dropped the intention to do this.
Fixes #153