Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React on keyboard height change #656

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

Ferossgp
Copy link
Contributor

Resolves #655

Keyboard state property changes only when the keyboard is opened or closed. But it does not react to changes that happen when the keyboard is already open. An example of such change is switch keyboard layout, or opening the emoji keyboard.

Motivation

By reacting to height change we solve the issue when the keyboard changes the height from a smaller to a bigger one. In such cases, the keyboard covers the content disallowing the user to interact with that part of the bottom sheet.

@gorhom gorhom added the v4 Written in Reanimated v2 label Sep 23, 2021
@gorhom
Copy link
Owner

gorhom commented Sep 23, 2021

thanks @Ferossgp for submitting this pr <3

@gorhom gorhom merged commit 3c5fc57 into gorhom:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Written in Reanimated v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4] Bottom sheet does not react on keybaord height change
2 participants